RFR: JDK-8293313: NMT: Rework MallocLimit [v9]

[Thomas Stuefe]

On Thu, 16 Feb 2023 16:12:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8293313-NMT-fake-oom
>>  - nullptr
>>  - merge and fix conflicts
>>  - Merge; fix conflicts
>>  - Feedback Gerard
>>  - Revert strchrnul
>>  - Copyrights
>>  - Feedback Johan
>>  - Merge
>>  - Merge branch 'master' into JDK-8293313-NMT-fake-oom
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/98a392c4...2d02a5bd
>
> Thanks guys!
> 
>> LGTM.
>> 
>> Will there be a release note documenting the changed/removed XX-flags ? Maybe there should be one .
> 
> That is not necessary since this was a diagnostic switch. Also, the new format is backward compatible with the old one (so no behavioral change if someone had set it)
> 
> Cheers, Thomas

> @tstuefe with regards to a release note ... while the flag is now diagnostic that is a change made in JDK 21, so in terms of users of JDK 20 migrating to JDK 21, a release note may be need to both explain the flag is now diagnostic (and subject to change without notice), and that "none" is no longer a valid value.

I assume you mean JDK-8302129, right? The MetaspaceReclaimPolicy=none removal? 

Makes sense, I will do that. I opened https://bugs.openjdk.org/browse/JDK-8302708 to track that.

-------------

PR: https://git.openjdk.org/jdk/pull/11371