RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms

[Robbin Ehn]

On Thu, 16 Feb 2023 19:56:42 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> src/hotspot/share/runtime/deoptimization.cpp line 110:
>> 
>>> 108:   MutexLocker ml(CompiledMethod_lock, Mutex::_no_safepoint_check_flag);
>>> 109:   // If there is nothing to deopt _gen is the same as comitted.
>>> 110:   _gen = DeoptimizationScope::_committed_deopt_gen;
>> 
>> Could we find a better name for the "_gen" member? If I'm reading this right, it's some kind of _required_gen, right? As in we need to have committed up until this number, or it isn't safe to continue.
>
> The comment from deoptimization.hpp is this:
> 
>   // The highest gen we need to execute/wait for
>   uint64_t _gen;
> 
> so better names might be: `_highest_gen` or `_highest_required_gen` or Erik's
> `_required_gen`. In any case, if you rename this field, please update the comment
> in deoptimization.hpp to match...

Fixed, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12585