Integrated: 8302070: Factor null-check into load_klass() calls

Roman Kennke rkennke at openjdk.org
Mon Feb 20 15:16:38 UTC 2023


On Wed, 8 Feb 2023 12:55:29 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> In several asm routines, a pattern like the following can be found:
> 
>         __ null_check(obj, oopDesc::klass_offset_in_bytes());
>         __ load_klass(klass, obj, tmp);
> 
> The null-check logically belongs into load_klass(), though. This becomes apparent in Lilliput, where the klass-offset is different, depending on whether or not Lilliput is enabled.
> 
> Testing:
>  - [x] tier1 x86_64
>  - [x] tier1 aarch64

This pull request has now been integrated.

Changeset: 7cf7e0a2
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7cf7e0a20b37522b0c7a97e5269bcd2eed174dbe
Stats:     89 lines in 28 files changed: 41 ins; 25 del; 23 mod

8302070: Factor null-check into load_klass() calls

Reviewed-by: phh, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/12473


More information about the hotspot-dev mailing list