RFR: 8302905: arm32 Raspberry Pi OS build broken by JDK-8301494
Martin Buchholz
martin at openjdk.org
Tue Feb 21 01:16:27 UTC 2023
On Tue, 21 Feb 2023 00:20:51 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Trivial fix that replaces `nullptr` with 0 in `intptr_t` expressions. This seems more appropriate than casting `nullptr` to `intptr_t`.
>
> Tested with local ARM32 build.
>
> Thanks.
This fixes my build.
I would have preferred using ((intptr_t)0) instead of 0.
BTW:
hotspot is full of type-punning code with undefined behavior.
TODO: convert hotspot to use bit_cast https://en.cppreference.com/w/cpp/numeric/bit_cast
-------------
Marked as reviewed by martin (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12679
More information about the hotspot-dev
mailing list