RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v4]

Coleen Phillimore coleenp at openjdk.org
Tue Feb 21 21:21:48 UTC 2023


On Tue, 21 Feb 2023 19:52:54 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.cpp line 1614:
>> 
>>> 1612: // before a new class is used.
>>> 1613: 
>>> 1614: void SystemDictionary::add_to_hierarchy(InstanceKlass* k, JavaThread* current) {
>> 
>> Since you're changing add_to_hierarchy so much, I think you might as well move it to InstanceKlass also.
>> 
>> These changes look good. Removing the Compile_lock around dictionary update can be done later (at at lower priority).
>
> Hi Coleen, so I looked at moving it to IK.
> There will be some additional changes, some method may now be private instead, etc...
> You think this should be done here?

ok, maybe it's ok where it is and we can move it with a future RFE.

-------------

PR: https://git.openjdk.org/jdk/pull/12585


More information about the hotspot-dev mailing list