RFR: 8302798: Refactor -XX:+UseOSErrorReporting for noreturn crash reporting

[Kim Barrett]

On Thu, 23 Feb 2023 08:08:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > I've included comments about how the ARA stuff and xxx_maybe_die_xxx exist only to support +UseOSErrorReporting. I could go further and add something like the following at the beginning of VMError::report_and_maybe_die_impl:
> > ```
> >   assert(after_report_action == AfterReportAction::Die
> >          WINDOWS_ONLY(|| UseOSErrorReporting),
> >          "must terminate");
> > ```
> >   
> > The reason for the new argument is so that the caller, which is where the knowlege of whether return or termination is desired, can request what it wants. I could have further uglified the code by making ARA::Return Windows-only, with more #ifdefs. I'd kind of prefer not to do that.
> 
> Okay, I think above assert would be a reasonable compromise; thanks for addressing this concern.

Added the assert.

-------------

PR: https://git.openjdk.org/jdk/pull/12651