RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v4]

Robbin Ehn rehn at openjdk.org
Thu Feb 23 12:50:15 UTC 2023


On Wed, 22 Feb 2023 06:24:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Coleen fix
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1489:
> 
>> 1487:   }
>> 1488: 
>> 1489:   // Add the new class. We need recompile lock during update of CHA.
> 
> This comment belongs after `add_to_hierarchy`.

Not sure that make sense. Also we have no "recompile" lock.
I plainly removed this comment.

> src/hotspot/share/classfile/systemDictionary.cpp line 1635:
> 
>> 1633:     // Note: must be done *after* linking k into the hierarchy (was bug 12/9/97)
>> 1634:     if (Universe::is_fully_initialized()) {
>> 1635:       CodeCache::mark_dependents_on(&deopt_scope, k);
> 
> The flush comment no longer matches the code.

Fixed

-------------

PR: https://git.openjdk.org/jdk/pull/12585


More information about the hotspot-dev mailing list