RFR: JDK-8302989: Add missing INCLUDE_CDS checks

Lutz Schmidt lucy at openjdk.org
Thu Feb 23 14:42:04 UTC 2023


On Tue, 21 Feb 2023 14:42:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
> However at some places INCLUDE_CDS is missing and should be added.
> 
> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?

Looks good to me. 
"Don't compile inactive code" is a good principle.

-------------

Marked as reviewed by lucy (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12691


More information about the hotspot-dev mailing list