RFR: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms [v5]

Robbin Ehn rehn at openjdk.org
Thu Feb 23 20:14:37 UTC 2023


On Thu, 23 Feb 2023 17:26:28 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More review fixes
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1610:
> 
>> 1608: // ----------------------------------------------------------------------------
>> 1609: // Update hierarchy. This is done before the new klass has been added to the SystemDictionary. The Compile_lock
>> 1610: // is held, to ensure that the compiler is not using the class hierarchy.
> 
> nit: s/is held/is grabbed/
> Adjust the header comment to reflect that we now grab the Compile_lock
> in the function rather than expecting it to be grabbed by the caller.

Fixed, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12585


More information about the hotspot-dev mailing list