RFR: JDK-8302989: Add missing INCLUDE_CDS checks

[David Holmes]

On Tue, 21 Feb 2023 14:42:38 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
> However at some places INCLUDE_CDS is missing and should be added.
> 
> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?

How much space in libjvm does this save? There is a trade-off with code readability when doing this.

If the aim is to get 100% conditional code then you need to do more. Do plan to do that or just this small tweak?

-------------

PR: https://git.openjdk.org/jdk/pull/12691