RFR: 8302780: Add support for vectorized arraycopy GC barriers [v2]

Erik Österlund eosterlund at openjdk.org
Fri Feb 24 11:04:08 UTC 2023


On Thu, 23 Feb 2023 15:02:58 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   RISC-V fixes
>
> src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp line 218:
> 
>> 216:     fatal("No support for 8 bytes copy");
>> 217: #endif
>> 218:   }
> 
> I believe the intent would be clearer using `switch`.

I tried both, but I actually found it less clear with switch as I then have to worry about a missing break; which would be accepted by the compiler and just yield subtly incorrect machine code. I'm open to doing switch though if you really do think it is more clear then. What do you think?

-------------

PR: https://git.openjdk.org/jdk/pull/12670


More information about the hotspot-dev mailing list