RFR: 8302491: NoClassDefFoundError omits the original cause of an error [v3]

[Ilarion Nakonechnyy]

On Wed, 22 Feb 2023 04:57:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ilarion Nakonechnyy has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Get rid of redundant code -
>>    merge get_cause_with_stack_trace and get_cause_simple
>>  - Review corrections
>
> src/hotspot/share/oops/cpCache.cpp line 476:
> 
>> 474:   Symbol* message = java_lang_Throwable::detail_message(PENDING_EXCEPTION);
>> 475:   // Try to discover the cause
>> 476:   oop cause = java_lang_Throwable::cause(PENDING_EXCEPTION);
> 
> This enhancement is unrelated to the current JBS issue. I think it a good enhancement but it should be done separately.

I removed it from this PR. 

The attached testcase doesn't cover this enhancement, but one of my other tests, which emulates SOE during the loading class, fails without SOE in a stacktrace if I remove these lines (Tested on mac os) 
Do you mind me asking for any clue, on how I can rework the testcase in att. for verifying enhancement in this file separately, in a separate JBS issue?

-------------

PR: https://git.openjdk.org/jdk/pull/12566