RFR: 8303068: Memory leak in DwarfFile::LineNumberProgram::run_line_number_program

[Johan Sjölen]

On Fri, 24 Feb 2023 04:48:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

> After allocating:
> 
> _state = new (std::nothrow) LineNumberProgramState(_header);
> 
> we need to `delete _state` before returning.
> 
> Testing: tiers 1-3
> 
> Thanks.

#else
   DWARF_LOG_DEBUG("Address:              Line:    Column:   File:");
 #endif
-  _state = new (std::nothrow) LineNumberProgramState(_header);
+  LineNumberProgramState state{_header};
+  _state = &state;
   if (_state == nullptr) {
     DWARF_LOG_ERROR("Failed to create new LineNumberProgramState object");
     return false;


Isn't this equivalent?

-------------

PR: https://git.openjdk.org/jdk/pull/12738