RFR: 8303068: Memory leak in DwarfFile::LineNumberProgram::run_line_number_program

Justin King jcking at openjdk.org
Sun Feb 26 17:03:03 UTC 2023


On Sun, 26 Feb 2023 10:30:51 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> ```
>  #else
>    DWARF_LOG_DEBUG("Address:              Line:    Column:   File:");
>  #endif
> -  _state = new (std::nothrow) LineNumberProgramState(_header);
> +  LineNumberProgramState state{_header};
> +  _state = &state;
>    if (_state == nullptr) {
>      DWARF_LOG_ERROR("Failed to create new LineNumberProgramState object");
>      return false;
> ```
> 
> Isn't this equivalent?

You'd have to clear _state before returning from the function for safety.

-------------

PR: https://git.openjdk.org/jdk/pull/12738


More information about the hotspot-dev mailing list