RFR: 8302191: Performance degradation for float/double modulo on Linux [v2]

David Holmes dholmes at openjdk.org
Mon Feb 27 02:26:09 UTC 2023


On Tue, 21 Feb 2023 13:51:10 GMT, Jan Kratochvil <duke at openjdk.org> wrote:

>> I have OCA already processed/approved. I am not Author but my Author request is being processed these days (sent to Rob McKenna).
>> I did regression test x86_64 OpenJDK-8. I will leave other regression testing on GHA.
>> The patch (and former GCC performance regression) affects only x86_64+i686.
>
> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8302191: Performance degradation for float/double modulo on Linux

Changes requested by dholmes (Reviewer).

src/hotspot/cpu/x86/sharedRuntime_x86.cpp line 97:

> 95: jne    1b        \n\
> 96: "
> 97:     :"=t"(retval)

This doesn't compile on Windows

 c:\sb\prod\1677461706\workspace\open\src\hotspot\cpu\x86\sharedRuntime_x86.cpp(97): error C2059: syntax error: ':'
c:\sb\prod\1677461706\workspace\open\src\hotspot\cpu\x86\sharedRuntime_x86.cpp(114): error C2059: syntax error: ':'

I assume this asm is gcc based.

-------------

PR: https://git.openjdk.org/jdk/pull/12508


More information about the hotspot-dev mailing list