RFR: 8292059: Do not inline InstanceKlass::allocate_instance()

[Claes Redestad]

On Tue, 28 Feb 2023 11:11:54 GMT, Afshin Zafari <duke at openjdk.org> wrote:

> The inline and not-inline versions of the method is stress tested to compare the performance difference. The statistics are drawn in the following chart.
> ![chart (2)](https://user-images.githubusercontent.com/4697012/221848555-2884313e-9d26-41c9-a265-3f1ce295b17b.png)
> 
> The vertical axis is in milliseconds.

So if I'm reading this correctly then by removing the inlining we see a reduction in performance on some GC metrics on some unspecified workload by 5-10%? I'd say that's a good data point in favor of keeping this as-is, unless there's data to show that there are compelling improvements elsewhere (for example binary size, compilation times). @iklam might want to comment on this, but it seems to me this might be a poor trade-off.

-------------

PR: https://git.openjdk.org/jdk/pull/12782