RFR: 8299378: sprintf is deprecated in Xcode 14 [v2]

David Holmes dholmes at openjdk.org
Tue Jan 3 07:00:50 UTC 2023


On Wed, 28 Dec 2022 07:01:19 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> The `sprintf` is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812), but the test was not covered. The failure was [reported later](https://github.com/openjdk/jdk/pull/11115#issuecomment-1344973773), while gtest is enabled for building.
>> 
>> This patch is just to make sure the building could pass.   Other than that, the use of `sprintf` in other places are not touched.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include os

Seems fine. Thanks. One nit below.

test/hotspot/gtest/utilities/test_unsigned5.cpp line 25:

> 23: 
> 24: #include "precompiled.hpp"
> 25: #include "runtime/os.hpp"

Nit: please sort includes alphabetically

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11793


More information about the hotspot-dev mailing list