RFR: 8298377: JfrVframeStream causes deadlocks in ZGC [v2]

Markus Grönlund mgronlun at openjdk.org
Tue Jan 3 13:56:51 UTC 2023


On Fri, 23 Dec 2022 14:53:38 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> The JfrVFrameStream is used while generating stack traces for events. One of the events are the ZPage allocation event. This event is sometimes sent when ZGC is relocating. The current implementation of JfrVFrameStream uses WalkContinuation::include, which causes JFR to walk the continuation and perform GC barriers. This is problematic, since ZGC has a requirement that we never perform load barriers while running the relocation code. If we do, we might end up performing other reloctions from the the relocation code, and in some cases that causes dead locks. 
>> 
>> I propose that JFR doesn't walk the stack during stack watermark processing. This PR implements that change. This PR replaces https://github.com/openjdk/jdk/pull/11586
>
> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix release build

The upshot with this solution compared to not having stacktraces for the ZPage Allocation Event is that only the relocation parts are sensitive? Other allocation sites can still have stacktraces?

-------------

PR: https://git.openjdk.org/jdk/pull/11778


More information about the hotspot-dev mailing list