RFR: 8299125: UnifiedOopRef in JFR leakprofiler should treat thread local oops correctly [v2]

Markus Grönlund mgronlun at openjdk.org
Tue Jan 3 16:21:50 UTC 2023


On Tue, 3 Jan 2023 15:26:34 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> I do not remember exactly. But I think there was some ref which on 64 bit which had the third bit set. That is this assert failed:
>> `assert((reinterpret_cast<uintptr_t>(ref) & UnifiedOopRef::tag_mask) == 0, "Unexpected low-order bits");`
>> I have to remove the shift and test again. I think it is strange given that `ObjectAlignmentInBytes >= 8` but we added the shift for some reason. Or maybe I am just missing something obvious.
>
> ObjectAlignmentInBytes is 4 by default on 32 bit VMs.

@fisk Why are the shifts needed on 64-bits?

-------------

PR: https://git.openjdk.org/jdk/pull/11741


More information about the hotspot-dev mailing list