RFR: 8299274: Add elements to resolved_references consistently

[David Holmes]

On Tue, 3 Jan 2023 18:35:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I added a resolved_references_at and set_resolved_references_at() functions to use for accesses to the resolved_references array, except for the CDS usages. This has an assert that the element is an oop and oob checks and setting elements use a CAS consistently.
> These asserts seem useful for finding the bug causing https://bugs.openjdk.org/browse/JDK-8296915.
> Tested with tiers1-4.

Looks good - nice simplification. Just one issue with naming.

Thanks

src/hotspot/share/oops/constantPool.cpp line 174:

> 172: }
> 173: 
> 174: oop ConstantPool::resolved_references_at(int index) const {

This function should be called `resolved_reference_at` - singular - as it returns one reference. Thanks.

src/hotspot/share/oops/constantPool.cpp line 181:

> 179: 
> 180: // Use a CAS for multithreaded access
> 181: oop ConstantPool::set_resolved_references_at(int index, oop new_result, oop old_result) {

This function should be called `set_resolved_reference_at` - singular - as it sets one reference. Thanks.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11834