RFR: 8274400: HotSpot Style Guide should permit use of alignof [v4]

Julian Waters jwaters at openjdk.org
Wed Jan 4 13:15:50 UTC 2023


On Sat, 31 Dec 2022 04:12:29 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - <type_traits>
>>  - Merge remote-tracking branch 'upstream/master' into alignof
>>  - Make section more brief
>>  - Merge remote-tracking branch 'upstream/master' into alignof
>>  - More Descriptive Version
>>  - Merge remote-tracking branch 'upstream/master' into alignof
>>  - HotSpot Style Guide should permit use of alignof
>
> doc/hotspot-style.md line 575:
> 
>> 573: * `#include <new>` to use placement `new`, `std::nothrow`, and `std::nothrow_t`.
>> 574: * `#include <limits>` to use `std::numeric_limits`.
>> 575: * `#include <type_traits>` with some considerations, listed below.
> 
> s/considerations/restrictions/

Changed, thanks

> doc/hotspot-style.md line 578:
> 
>> 576: * `#include <cstddef>` to use `std::nullptr_t` and `std::max_align_t`.
>> 577: 
>> 578: Certain declarations from `<type_traits>` should be avoided.
> 
> s/should be avoided/are forbidden/

I'll just rewrite this one to say it has restrictions that apply to it, to match the line about it from above

-------------

PR: https://git.openjdk.org/jdk/pull/11761


More information about the hotspot-dev mailing list