RFR: 8298377: JfrVframeStream causes deadlocks in ZGC [v2]

[Markus Grönlund]

On Wed, 4 Jan 2023 15:33:46 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> The reason for asking is for upcoming changes that try to minimize everything involved in sampling. Is this only needed for virtual threads?
>
> I see. It is indeed only needed for virtual threads. If you are going to perform very frequent sampling, then it's worth mentioning that the check if the processing already started requires load_acquire on non-TSO platforms. I suppose that would be the dominating cost. But for this load_acquire to start showing up as a significant overhead, I think you would have to do sampling in the order of magnitude of hundreds of nanosecond interval levels. So unless you are getting to such intense frequencies, I think I would still not worry about it. What do you think?

Thanks for the information, Erik. I think we can go with your solution, I will take the information about virtual threads into account for later, there is still a lot of magic left that needs to be done in the new sampling system in order to incorporate them.

-------------

PR: https://git.openjdk.org/jdk/pull/11778