RFR: 8299274: Add elements to resolved_references consistently [v2]

[Coleen Phillimore]

> I added a resolved_references_at and set_resolved_references_at() functions to use for accesses to the resolved_references array, except for the CDS usages. This has an assert that the element is an oop and oob checks and setting elements use a CAS consistently.
> These asserts seem useful for finding the bug causing https://bugs.openjdk.org/browse/JDK-8296915.
> Tested with tiers1-4.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Change to objArrayOop to replace_if_null since that is what it's doing.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11834/files
  - new: https://git.openjdk.org/jdk/pull/11834/files/d10796da..50ff492c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11834&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11834&range=00-01

  Stats: 14 lines in 6 files changed: 0 ins; 1 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/11834.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11834/head:pull/11834

PR: https://git.openjdk.org/jdk/pull/11834