RFR: 8299274: Add elements to resolved_references consistently [v3]

[Ioi Lam]

On Wed, 4 Jan 2023 15:11:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>>> I need it to return the existing value for the code in resolve_constant_at_impl().
>> 
>> So it's a getter/setter, but if the argument must be nullptr, I think we should skip it.
>
> obj_at_put already checks the index.

I agree with David's naming. 

For grepping, it's better to grep for the singular form as there are already functions that use the singular form. 


$ find src/hotspot -type f | xargs grep resolved_reference | grep -v references | wc
     41     223    4559


Here are some examples. If you grep for the plural form, you will miss them.


./share/oops/constantPool.cpp:  set_resolved_reference_length(
./share/oops/constantPool.hpp:    int                _resolved_reference_length;
./share/oops/cpCache.hpp:  void initialize_resolved_reference_index(int ref_index) {

-------------

PR: https://git.openjdk.org/jdk/pull/11834