RFR: 8299274: Add elements to resolved_references consistently [v3]

[David Holmes]

On Thu, 5 Jan 2023 14:58:20 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I added a resolved_references_at and set_resolved_references_at() functions to use for accesses to the resolved_references array, except for the CDS usages. This has an assert that the element is an oop and oob checks and setting elements use a CAS consistently.
>> These asserts seem useful for finding the bug causing https://bugs.openjdk.org/browse/JDK-8296915.
>> Tested with tiers1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change the name to resolved_reference_at because there's a resolved_klass_at but I don't like this name as much as having resolved_references (plural) in the name.

> @dholmes-ora are you holding out until I change the name to something I don't agree with ?

No I was waiting to see if anyone else had an opinion on it. :)

Thanks for making the change.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11834