RFR: 8299089: Instrument global jni handles with tag to make them distinguishable
Andrey Turbanov
aturbanov at openjdk.org
Mon Jan 9 09:44:51 UTC 2023
On Tue, 20 Dec 2022 11:44:33 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> Weak global jni handles are tagged so the GC can distinguish them when resolving the object. Today there is no cheap way of distinguishing global jni handles from local jni handles. For generational ZGC the OopStorage handles and the thread local handles semantical difference requires the handles to be distinguishable.
>
> This enhancements instruments the jni handles with a global tag similarly to the jweak tag.
>
> Note:
> * the s390 implementation has minimal changes and requires improvement.
> * There is room for enchantment here to create the same abstraction that ppc uses for all platforms, i.e. move the resolve_jobject from the MacroAssembler to the BarrierSetAssembler which allows for more optimised code for GCs that can treat local and global handles the same.
>
> Testing: GHA. Oracle supported platforms tier1-3. Will run higher tiers. Has also been tested on the generational branch of ZGC for over three months. Requires testing on non Oracle platforms.
test/hotspot/jtreg/runtime/jni/FastGetField/FastGetField.java line 134:
> 132: long duration = System.nanoTime();
> 133: for (int c = 0; c < loop_cnt; ++c) {
> 134: if (accessFields() != 0l) throw new RuntimeException("Wrong initial result!");
nit:
Suggestion:
if (accessFields() != 0L) throw new RuntimeException("Wrong initial result!");
-------------
PR: https://git.openjdk.org/jdk/pull/11740
More information about the hotspot-dev
mailing list