RFR: JDK-8299688: Adopt C++14 compatible std::bit_cast introduced in C++20 [v2]

Justin King jcking at openjdk.org
Mon Jan 9 15:45:20 UTC 2023


On Mon, 9 Jan 2023 15:09:59 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apple Clang thinks __builtin_bit_cast is present when its not
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp line 35:
> 
>> 33: #include "orderAccess_linux_ppc.hpp"
>> 34: #include "utilities/debug.hpp"
>> 35: #include "utilities/bitCast.hpp"
> 
> Sort includes

Done.

> src/hotspot/os_cpu/windows_aarch64/atomic_windows_aarch64.hpp line 63:
> 
>> 61:     return bit_cast<D>(                                 \
>> 62:       IntrinsicName(reinterpret_cast<IntrinsicType volatile *>(dest),     \
>> 63:                     bit_cast<IntrinsicType>(add_value))); \
> 
> Could you realign the `` characters? The same comment applies to other places in this patch.

Believe I got them all now.

-------------

PR: https://git.openjdk.org/jdk/pull/11865


More information about the hotspot-dev mailing list