RFR: 8299032: Interface IN_NATIVE oop stores for C2

Erik Österlund eosterlund at openjdk.org
Tue Jan 10 09:39:51 UTC 2023


On Tue, 10 Jan 2023 02:00:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Not a review, since I'm not sufficiently knowledgeable about C2 to really do justice to it. Rather, a couple questions/comments.
> 
> We made a concerted effort to reduce/eliminate oops in native storage, instead using OopStorage entries. This kind of feels like backsliding on that effort. Why?

It isn't a backsliding on that effort. This code is indeed using OopStorage. An OopHandle::replace uses IN_NATIVE stores. This is essentially an intrinsic that replaces the contents of an OopHandle, so similarly it should use an IN_NATIVE store for that. Having said that, perhaps it would have been more clear if there was a high level function of some sort with a name like oop_handle_replace containing the IN_NATIVE store?

-------------

PR: https://git.openjdk.org/jdk/pull/11777


More information about the hotspot-dev mailing list