RFR: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug [v4]

Thomas Stuefe stuefe at openjdk.org
Tue Jan 10 13:04:56 UTC 2023


On Tue, 10 Jan 2023 12:38:03 GMT, Afshin Zafari <duke at openjdk.org> wrote:

> > @afshin-zafari, thank you for finding and fixing this.
> > I worry that this may be too fragile, since it depends on linker hints that AFAIK the linker could ignore. Could we instead match with something like `"# .*(VMError::controlled_crash|crash_with).*"`?
> 
> `ALWAYSINLINE` or its expanded form `__attribute__ (always_inline)` will prevail all other compile options for inlining (particularly compiler optimisation options) , e.g. limit number and/or do or don't inlining. So it would not be ignored as was not in tier 1-5 tests.

Okay, good enough then. Just wanted to prevent false positives (we had a lot of work when writing tests for NMT call stack matching).

+1

-------------

PR: https://git.openjdk.org/jdk/pull/11704


More information about the hotspot-dev mailing list