RFR: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug [v4]

[Daniel D. Daugherty]

On Tue, 10 Jan 2023 11:57:22 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> ### Description
>> The following problems found and solved:
>> 
>> 1) Reporting which regex pattern did not match with error messages was incorrect. To report the mismatched pattern, the head of the pattern list was peeked, while it was the already peeked item from that did not match. So the next pattern to the mismatched one was reported.
>> 
>> 2) The pattern for finding a crash was incorrectly set to "# .*VMError::controlled_crash.*", while it has to be "# .*crash_with_segfault.*".
>> 
>> 3) `crash_with_segfault` function is too small and was `inline`d in compiler optimisations. So it was not in the stack trace when the error message is created.
>> 
>> ### Patch
>> 1 and 2 corrected and added the `NOINLINE` to  the `crash_with_segfault` signature. The same applied for `crash_with_sigfpe` function.
>> 
>> ### Test
>> runtime/ErrorHandling/* and tier1-5
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

You need to backout the copyright year changes to the two test files that
are no longer modified by this patch.

test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java line 3:

> 1: /*
> 2:  * Copyright (c) 2014, 2022 SAP SE. All rights reserved.
> 3:  * Copyright (c) 2014, 2023, Oracle and/or its affiliates. All rights reserved.

There are no longer any changes to this file in this patch so the
copyright year update should be backed out.

test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java line 2:

> 1: /*
> 2:  * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.

There are no longer any changes to this file in this patch so the
copyright year update should be backed out.

-------------

Changes requested by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11704