RFR: 8298321: 2 File Leak defect groups in 2 files [v4]
Calvin Cheung
ccheung at openjdk.org
Tue Jan 10 20:21:25 UTC 2023
> Please review this simple change for fixing two file leak warnings:
> 1) DirectivesParser::parse_from_file_inner() in open/src/hotspot/share/compiler/directivesParser.cpp
> 2) mmap_attach_shared() in open/src/hotspot/os/posix/perfMemory_posix.cpp
>
> Please refer to the [comment](https://bugs.openjdk.org/browse/JDK-8298321?focusedCommentId=14549361&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14549361) in the bug report for details.
>
> Passed tiers 1 and 2 testing.
Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
move the ::close call to immediately after ::read
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11909/files
- new: https://git.openjdk.org/jdk/pull/11909/files/56980b79..6439276c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11909&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11909&range=02-03
Stats: 4 lines in 1 file changed: 1 ins; 3 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/11909.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11909/head:pull/11909
PR: https://git.openjdk.org/jdk/pull/11909
More information about the hotspot-dev
mailing list