RFR: JDK-8299672: Enhance HeapDump JFR event [v2]

Christoph Langer clanger at openjdk.org
Wed Jan 11 11:27:19 UTC 2023


On Wed, 11 Jan 2023 11:23:09 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Enhance the JFR Event HeapDump  with the additional interesting fields, compression and overwrite.
>> Add some UL logging in case the heap dump writing failed .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust compression check to below in TestHeapDump.java

Some spelling issues, for consistency.

src/hotspot/share/jfr/metadata/metadata.xml line 1147:

> 1145:   </Event>
> 1146: 
> 1147:   <Event name="HeapDump" category="Java Virtual Machine, Diagnostics" label="Heap Dump" description="Information about a successfully written Java Heap dump"

spelling: "Java heap dump" in description (small heap)

src/hotspot/share/jfr/metadata/metadata.xml line 1149:

> 1147:   <Event name="HeapDump" category="Java Virtual Machine, Diagnostics" label="Heap Dump" description="Information about a successfully written Java Heap dump"
> 1148:     stackTrace="true" thread="true">
> 1149:     <Field type="string" name="destination" label="Destination path of the dump" />

Spelling: In the label we'd write Path and Dump in capitals

src/hotspot/share/jfr/metadata/metadata.xml line 1152:

> 1150:     <Field type="long" name="size" label="Size" />
> 1151:     <Field type="boolean" name="gcBeforeDump" label="GC Before Dump" />
> 1152:     <Field type="boolean" name="onOutOfMemoryError" label="Heap dump on Out of Memory Error" />

Also here: "Dump" in capitals in the label

src/hotspot/share/jfr/metadata/metadata.xml line 1154:

> 1152:     <Field type="boolean" name="onOutOfMemoryError" label="Heap dump on Out of Memory Error" />
> 1153:     <Field type="boolean" name="overwrite" label="Overwrite" description="Heap dump overwrites previous file location if it exists" />
> 1154:     <Field type="int" name="compression" label="Compression Level" description="Compression level of the Dump, if larger than 0 we use gzip compressoion with this level" />

Here, in description, use small letter for "dump"

-------------

Changes requested by clanger (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11864


More information about the hotspot-dev mailing list