RFR: 8300002: Performance regression caused by non-inlined hot methods due to post call noop instructions
Sergey Kuksenko
skuksenko at openjdk.org
Fri Jan 13 19:19:23 UTC 2023
On Thu, 12 Jan 2023 06:16:14 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> If you update the last usage in `ciMethod::has_compiled_code()`, it looks like `ciMethod::instructions_size` is not needed anymore and can be removed. Instead, you could just change its semantic to exclude nops (please also update the method's comments).
I thought about it.
The issue is naming. "instructions_size" says nothing about the fact that nop instructions were excluded.
On the other side using "inline_instructions_size" in `ciMethod::has_compiled_code()` looks weird.
I am open to any suggestions.
-------------
PR: https://git.openjdk.org/jdk/pull/11958
More information about the hotspot-dev
mailing list