Integrated: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

Afshin Zafari duke at openjdk.org
Mon Jan 16 12:40:17 UTC 2023


On Fri, 16 Dec 2022 07:56:39 GMT, Afshin Zafari <duke at openjdk.org> wrote:

> ### Description
> The following problems found and solved:
> 
> 1) Reporting which regex pattern did not match with error messages was incorrect. To report the mismatched pattern, the head of the pattern list was peeked, while it was the already peeked item from that did not match. So the next pattern to the mismatched one was reported.
> 
> 2) The pattern for finding a crash was incorrectly set to "# .*VMError::controlled_crash.*", while it has to be "# .*crash_with_segfault.*".
> 
> 3) `crash_with_segfault` function is too small and was `inline`d in compiler optimisations. So it was not in the stack trace when the error message is created.
> 
> ### Patch
> 1 and 2 corrected and added the `NOINLINE` to  the `crash_with_segfault` signature. The same applied for `crash_with_sigfpe` function.
> 
> ### Test
> runtime/ErrorHandling/* and tier1-5

This pull request has now been integrated.

Changeset: 289aed46
Author:    Afshin Zafari <afshin.zafari at oracle.com>
Committer: Robbin Ehn <rehn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/289aed465e9b8449938d4cdb515748e7aca1d070
Stats:     4 lines in 2 files changed: 0 ins; 0 del; 4 mod

8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

Reviewed-by: dcubed, dholmes, stuefe

-------------

PR: https://git.openjdk.org/jdk/pull/11704


More information about the hotspot-dev mailing list