RFR: JDK-8293313: NMT: Rework MallocLimit [v2]

[Thomas Stuefe]

On Mon, 16 Jan 2023 14:25:14 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8293313-NMT-fake-oom
>>  - MallocLimit
>
> test/hotspot/gtest/nmt/test_nmt_malloclimit.cpp line 82:
> 
>> 80: }
>> 81: 
>> 82: TEST(NMT, malloclimit_per_category) {
> 
>>malloclimit_per_category
> 
> Can we use CamelCase for test case names instead? This is a convention that we *should* use for gtest: http://google.github.io/googletest/faq.html
> 
> Unfortunately, we don't consistently do this, but I do want to avoid introducing new instances of this.

I can see the point, though my names often follow a vague hierarchy if the suitename is already very generic. E.g. "malloclimit_xxx". - suitename is "NMT" and should remain so, all tests in this file concern MallocLimit, and then something. I like to separate "MallocLimit" visually from the "something".

I guess its okay, just a minor annoyance.

-------------

PR: https://git.openjdk.org/jdk/pull/11371