RFR: 8300002: Performance regression caused by non-inlined hot methods due to post call noop instructions [v3]

[Igor Veresov]

On Mon, 16 Jan 2023 02:12:23 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Sergey Kuksenko has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - whitespace clenup
>>  - renaming; generalize; make methods independent on post call noops naming
>
> src/hotspot/share/asm/assembler.hpp line 248:
> 
>> 246:   class InlineSkippedInstructionsCounter: public StackObj {
>> 247:    private:
>> 248:     AbstractAssembler* _assm;
> 
> May be you should record `_assm->_code_section` instead and directly call `_code_section->register_skipped(_start)` instead of adding `AbstractAssembler:: register_skipped(size)`. With `CodeSection` code:
> 
>    register_skipped(address start) {
>       _skipped_instructions_size += (_end - start);
>    }

Or may be it should be done in the destructor of `InlineSkippedInstructionsCounter`? Would be IMO cleaner.

-------------

PR: https://git.openjdk.org/jdk/pull/11958