RFR: 8299973: Replace NULL with nullptr in share/utilities/ [v3]

David Holmes dholmes at openjdk.org
Thu Jan 19 09:32:48 UTC 2023


On Wed, 18 Jan 2023 22:44:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/utilities/debug.cpp line 425:
>> 
>>> 423:   CodeBlob* cb = CodeCache::find_blob((address)p);
>>> 424:   if (cb == nullptr) {
>>> 425:     tty->print_cr("nullptr");
>> 
>> Changes log, OK?
>
> I think it's ok. Unless we have tests that check for NULL, but they're likely in gtests and you'll find them pretty quickly and can fix them pretty quickly if they slip through.

Again I think "null" is preferable in this context.

-------------

PR: https://git.openjdk.org/jdk/pull/12015


More information about the hotspot-dev mailing list