RFR: 8299973: Replace NULL with nullptr in share/utilities/ [v3]

David Holmes dholmes at openjdk.org
Thu Jan 19 09:32:53 UTC 2023


On Thu, 19 Jan 2023 08:58:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_xlc.hpp line 85:
>> 
>>> 83: // In this case you need to copy the following defines to a position after #include <dirent.h>
>>> 84: #include <dirent.h>
>>> 85: #ifdef _LP64
>> 
>> This entire section seems wrong to me. Could you take a closer look at this part?
>
> I thought I reverted all of those! Good catch, fixed.

I agree this looks like it should not be changed.

-------------

PR: https://git.openjdk.org/jdk/pull/12015


More information about the hotspot-dev mailing list