RFR: 8299973: Replace NULL with nullptr in share/utilities/ [v4]

Johan Sjölen jsjolen at openjdk.org
Thu Jan 19 10:28:22 UTC 2023


On Thu, 19 Jan 2023 09:13:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions.cpp line 162:
>> 
>>> 160:   static_assert((size_t)HeapWordSize >= sizeof(juint),
>>> 161:                 "HeapWord should be at least as large as juint");
>>> 162:   static_assert(sizeof(nullptr) == sizeof(char*), "nullptr must be same size as pointer");
>> 
>> Adding in another static_assert here so that both cases are represented.
>
> Not sure this makes any sense for `nullptr`.

Yeah, I'm removing this static assert.

-------------

PR: https://git.openjdk.org/jdk/pull/12015


More information about the hotspot-dev mailing list