RFR: 8300682: InstanceKlassMiscStatus is a bad name

Frederic Parain fparain at openjdk.org
Thu Jan 19 22:04:50 UTC 2023


On Thu, 19 Jan 2023 21:50:46 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This patch is to simply rename InstanceKlassMiscStatus to InstanceKlassFlags.  This matches the naming for upcoming Field changes that add a FieldFlags class.
> Tested with tier1-4.

LGTM, just minor nits in instanceKlassFlags.hpp.

LGTM, just minor nits in instanceKlassFlags.hpp.

src/hotspot/share/oops/instanceKlassFlags.hpp line 30:

> 28: class ClassLoaderData;
> 29: 
> 30: class InstanceKlassFlags {

The macro to prevent multiple inclusions should have the same name as the file after the renaming.
Should we add a comment stating that "Flags" are immutable, and mutable status should be put elsewhere?

-------------

Changes requested by fparain (Committer).

PR: https://git.openjdk.org/jdk/pull/12106


More information about the hotspot-dev mailing list