RFR: JDK-8300582: Introduce interface for unaligned memory accesses [v2]

David Holmes dholmes at openjdk.org
Fri Jan 20 06:37:27 UTC 2023


On Wed, 18 Jan 2023 21:42:58 GMT, Justin King <jcking at openjdk.org> wrote:

>> Introduce interface for unaligned memory accesses `UnalignedAccess`, consolidate the byte swapping implementation to `byteswap`, and switch to a generic implementation of `Bytes`.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update comment to be correct
>   
>   Signed-off-by: Justin King <jcking at google.com>

I don't mind seeing some better code sharing in the "byte" stuff, but simply deleting all the platform specific files and then adding a tonne of platform ifdefs to what should be the shared code, has gone too far IMO.

Also I think the byte stuff should be separated out from the unaligned memory access interface. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12078


More information about the hotspot-dev mailing list