RFR: JDK-8300582: Introduce interface for unaligned memory accesses [v2]

Justin King jcking at openjdk.org
Fri Jan 20 14:39:41 UTC 2023


On Fri, 20 Jan 2023 06:34:34 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I don't mind seeing some better code sharing in the "byte" stuff, but simply deleting all the platform specific files and then adding a tonne of platform ifdefs to what should be the shared code, has gone too far IMO.

Okay, I realized after that all of the supported platforms use GCC/Clang, MSVC, or xlC. So we do not need the platform-specific headers. `byteswap` implementation is now more simple and follows the approach for `count_{leading,trailing}_zeros.hpp`.

> Also I think the byte stuff should be separated out from the unaligned memory access interface. Thanks.

I'll create a separate issue to consolidate the `byteswap` implementation and then re-base ontop of that when it is in.

-------------

PR: https://git.openjdk.org/jdk/pull/12078


More information about the hotspot-dev mailing list