RFR: JDK-8300783: Consolidate byteswap implementations [v2]

Justin King jcking at openjdk.org
Fri Jan 20 15:13:53 UTC 2023


> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.

Justin King has updated the pull request incrementally with four additional commits since the last revision:

 - Consolidate more byte swapping
   
   Signed-off-by: Justin King <jcking at google.com>
 - Fix template specialization
   
   Signed-off-by: Justin King <jcking at google.com>
 - Fix static_assert for Microsoft Visual Studio
   
   Signed-off-by: Justin King <jcking at google.com>
 - Remove final from ByteswapFallbackImpl
   
   Signed-off-by: Justin King <jcking at google.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12114/files
  - new: https://git.openjdk.org/jdk/pull/12114/files/2994a734..592d4f67

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=00-01

  Stats: 71 lines in 2 files changed: 23 ins; 42 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/12114.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114

PR: https://git.openjdk.org/jdk/pull/12114


More information about the hotspot-dev mailing list