RFR: 8292170: Convert CodeRootSetTable to use ResourceHashtable [v9]

Coleen Phillimore coleenp at openjdk.org
Tue Jan 24 18:52:08 UTC 2023


On Tue, 24 Jan 2023 18:10:28 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> I am replacing the old hash table with ResourceHashtable. In the process I am also removing the redundant `_length` field. By removing the `_length` field, a lot of asserts can be removed as the length will trivially match the length of the underlying table.
>> 
>> I would like to have feedback on the addition of `unlink_destruct(Function&& should_remove)`. I added it because I prefer to use a functor object that can be used by lambdas instead of an iterator object. However, I did add code to "destruct" resource objects when they are removed instead of just letting them be to reflect that we use `delete` on c-heap objects. Maybe I should remove this "improvement" and then maybe implement the function by calling the existing unlink?
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   include cleanups, test fix

Good, thank you for the cleanups and switching to the better Hashtable.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11675


More information about the hotspot-dev mailing list