RFR: JDK-8300241: Replace NULL with nullptr in share/classfile/

[Coleen Phillimore]

On Tue, 17 Jan 2023 11:13:22 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/classfile/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in
> a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

I didn't see any other places that needed changing.

src/hotspot/share/classfile/verifier.cpp line 2839:

> 2837:     // Found the entry for the signature's verification types in the hash table.
> 2838:     mth_sig_verif_types = *mth_sig_verif_types_ptr;
> 2839:     assert(mth_sig_verif_types != nullptr, "Unexpected nullptr sig_as_verification_types value");

Suggestion:

    assert(mth_sig_verif_types != nullptr, "Unexpected null sig_as_verification_types value");

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12030