RFR: JDK-8293313: NMT: Rework MallocLimit [v4]

[Thomas Stuefe]

On Tue, 24 Jan 2023 21:07:38 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Made more progress on the review today, tomorrow I have the parser to review and java tests...

Thanks for your review work! I'll wait for your full review before continuing.

> I would prefer to see `suppress_limit_handling()` checked inside `total_limit_reached()`, same for `category_limit_reached()`. This way we would force those APIs to always obey the suppression without having to bother to add `suppress_limit_handling()`, they could call `VMError::is_error_reported()` directly.

Note that `total_limit_reached()` and `category_limit_reached()` are private APIs. 

If we move `suppress_limit_handling()` into `total_limit_reached()`, `total_limit_reached()` would need to report it back to `MallocMemorySummary::check_exceeds_limit` since its processed there too, it affects the return code. So `total_limit_reached()` cannot be void anymore, and gets somewhat more complex. I prefer it this way, tbh.

-------------

PR: https://git.openjdk.org/jdk/pull/11371