RFR: 8301088: oopDesc::print_on should consistently use a trailing newline

Axel Boldt-Christmas aboldtch at openjdk.org
Wed Jan 25 14:03:49 UTC 2023


[JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161) added special printing when `oopDesc` contains `badHeapWordVal` or `badMetaWordVal`. However these two cases do not print a trailing newline. The previous behaviour was to always use a trailing newline.

Propose making this consistent with `*klass::oop_print_on` and `InstanceStackChunkKlass::print_chunk`, that both uses a trailing newline.

This new behaviour messes up some printing code, e.g. can be seen in print_location when printing hs_err files which assumes that it always prints a trailing newline.

-------------

Commit messages:
 - oopDesc::print_on should consistently use a trailing newline

Changes: https://git.openjdk.org/jdk/pull/12195/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12195&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301088
  Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/12195.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12195/head:pull/12195

PR: https://git.openjdk.org/jdk/pull/12195


More information about the hotspot-dev mailing list