RFR: 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler [v2]

Fei Yang fyang at openjdk.org
Thu Jan 26 03:37:47 UTC 2023


On Wed, 25 Jan 2023 20:18:38 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Comment
>>  - Merge branch 'master' into JDK-8301036
>>  - 8301036: RISC-V: Factor out functions baseOffset & baseOffset32 from MacroAssembler
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2394:
> 
>> 2392: 
>> 2393:   assert(Rd != noreg, "expecting a register");
>> 2394:   guarantee(Rd != base, "should be different registers");
> 
> Why not `assert`?

Fixed. These two lines come from the original MacroAssembler::baseOffset32. I think assert_different_registers will also do here.

-------------

PR: https://git.openjdk.org/jdk/pull/12177


More information about the hotspot-dev mailing list