Integrated: 8292170: Convert CodeRootSetTable to use ResourceHashtable
Leo Korinth
lkorinth at openjdk.org
Thu Jan 26 10:35:52 UTC 2023
On Wed, 14 Dec 2022 13:45:51 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
> I am replacing the old hash table with ResourceHashtable. In the process I am also removing the redundant `_length` field. By removing the `_length` field, a lot of asserts can be removed as the length will trivially match the length of the underlying table.
>
> I would like to have feedback on the addition of `unlink_destruct(Function&& should_remove)`. I added it because I prefer to use a functor object that can be used by lambdas instead of an iterator object. However, I did add code to "destruct" resource objects when they are removed instead of just letting them be to reflect that we use `delete` on c-heap objects. Maybe I should remove this "improvement" and then maybe implement the function by calling the existing unlink?
This pull request has now been integrated.
Changeset: 30cb305d
Author: Leo Korinth <lkorinth at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/30cb305dc1e717b6b7a1dc157638118ae913a61d
Stats: 899 lines in 18 files changed: 301 ins; 585 del; 13 mod
8292170: Convert CodeRootSetTable to use ResourceHashtable
Reviewed-by: coleenp, iwalulya, iklam
-------------
PR: https://git.openjdk.org/jdk/pull/11675
More information about the hotspot-dev
mailing list