RFR: 8301088: oopDesc::print_on should consistently use a trailing newline

Coleen Phillimore coleenp at openjdk.org
Thu Jan 26 12:57:18 UTC 2023


On Wed, 25 Jan 2023 13:56:08 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161) added special printing when `oopDesc` contains `badHeapWordVal` or `badMetaWordVal`. However these two cases do not print a trailing newline. The previous behaviour was to always use a trailing newline.
> 
> Propose making this consistent with `*klass::oop_print_on` and `InstanceStackChunkKlass::print_chunk`, that both uses a trailing newline.
> 
> This new behaviour messes up some printing code, e.g. can be seen in print_location when printing hs_err files which assumes that it always prints a trailing newline.

Ok.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12195


More information about the hotspot-dev mailing list